Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests in Commons IO. #46

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Fix tests in Commons IO. #46

merged 1 commit into from
Jul 24, 2020

Conversation

radcortez
Copy link
Member

No description provided.

@radcortez radcortez merged commit 4078421 into smallrye:master Jul 24, 2020
@dmlloyd
Copy link
Collaborator

dmlloyd commented Jul 25, 2020

This change is not correct: the default test profile is intended to run tests at the build JDK level and should not normally be disabled.

@radcortez
Copy link
Member Author

The tests are failing with the default profile, so we probably need @gastaldi to have a look and check if there is something to be done over there.

@dmlloyd
Copy link
Collaborator

dmlloyd commented Jul 27, 2020

I was looking at the MR JAR code and I think there is a better fix up at the parent level. I'm going to work something up and see what I get.

@radcortez radcortez added this to the 1.2.0 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@radcortez @dmlloyd @gastaldi