Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build and Sonar issues. #51

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Fix Build and Sonar issues. #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
767d8e7
Update to SmallRye Parent 23.
radcortez Jul 29, 2020
28f47ee
Fixed javadoc issues.
radcortez Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>io.smallrye</groupId>
<artifactId>smallrye-parent</artifactId>
<version>22</version>
<version>23</version>
</parent>

<groupId>io.smallrye.common</groupId>
Expand Down
3 changes: 3 additions & 0 deletions version/src/main/java/io/smallrye/common/version/VersionIterator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ default boolean isPart() {
* Append the current alphabetical part to the given string builder. If the iterator is not positioned on an
* alphabetical part (i.e. {@link #isAlphaPart()} returns {@code false}), then an exception is thrown.
*
* @param target the StringBuilder to append
* @return the current alphabetical part
* @throws IllegalStateException if the current token is not an alphabetical part
*/
Expand Down Expand Up @@ -176,6 +177,7 @@ int compareAlphaPart(String str, int offs, int len, boolean ignoreCase) throws I
* alphabetical parts or an exception is thrown.
*
* @param other the other iterator (must not be {@code null})
* @param ignoreCase a boolean to ignore case in the compare
* @return {@code -1}, {@code 0}, or {@code 1} if this segment is less than, equal to, or greater than the other
* iterator's part
* @throws IllegalStateException if this or the other iterator are not positioned on an alphabetical part
Expand All @@ -199,6 +201,7 @@ default String getNumberPartAsString() throws IllegalStateException {
* part (i.e. {@link #isNumberPart()} returns {@code false}), then an exception is thrown. Any redundant
* leading zeros are removed.
*
* @param target the StringBuilder to append
* @return the current numeric part as a {@code String}
* @throws IllegalStateException if the current token is not a numeric part
*/
Expand Down
4 changes: 2 additions & 2 deletions version/src/main/java/io/smallrye/common/version/VersionScheme.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ default void validate(String version) throws VersionSyntaxException {
* A basic versioning scheme which is roughly compatible with semantic versioning, GNU's scheme, the OpenSSL scheme,
* the numeric scheme used by Unix-style and ELF dynamic linkers, etc. The syntax of this scheme can be described
* with this grammar:
* <code><pre>
* <pre><code>

version ::= underscore-sequence
| version "." underscore-sequence
Expand All @@ -100,7 +100,7 @@ default void validate(String version) throws VersionSyntaxException {
digit ::= &lt;{@linkplain Character#isDigit(int) Unicode digits}&gt;

letter ::= &lt;{@linkplain Character#isLetter(int) Unicode letters}&gt;
</pre></code>
</code></pre>
* <p>
* Digit parts are sorted numerically (with leading zeros stripped). Alpha parts are sorted lexicographically and
* case-sensitively. Trailing zero segments are trimmed. When comparing two sequences, the shorter sequence is
Expand Down