Add @ConfigMapping beanStyleGetter to enable / disable bean style getter names matching with configuration names #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
radcortez
commented
Oct 8, 2024
radcortez
commented
- Fixes Are getters supported? #1230
…ter names matching with configuration names
dmlloyd
reviewed
Oct 8, 2024
| * <p> | ||
| * Config mapping declarations should prefer to use simple names that match one-to-one with their configuration | ||
| * names. Bean-style getter matching allows multiple method names to match the same configuration name. For | ||
| * instance, <code>getFoo</code> and <code>isFoo</code> both match <code>foo</code>, which may not be intended. |
There was a problem hiding this comment.
Do we know which one Kotlin uses? Maybe we should have this be an enum with each possiblity?
There was a problem hiding this comment.
From what I can tell is get, but you can override the name in Kotlin.
There was a problem hiding this comment.
@dmlloyd are you ok to merge as is? Or do you prefer something different?
There was a problem hiding this comment.
I had a thought to differentiate between these two cases, but I think it probably doesn't matter too much.
dmlloyd
approved these changes
Oct 15, 2024
| * <p> | ||
| * Config mapping declarations should prefer to use simple names that match one-to-one with their configuration | ||
| * names. Bean-style getter matching allows multiple method names to match the same configuration name. For | ||
| * instance, <code>getFoo</code> and <code>isFoo</code> both match <code>foo</code>, which may not be intended. |
There was a problem hiding this comment.
I had a thought to differentiate between these two cases, but I think it probably doesn't matter too much.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.