Use application classloader for proxies #419
Conversation
|
Thanks @tevans78 ! @radcortez can you take a look to see whether you have any comments? |
|
Thank you. Please, open this up to master and I'll rebase. Additional specific changes for the branch can be added later. |
| } | ||
| } | ||
|
|
||
| private static Class<?> loadClass(final String className, final byte[] classBytes) { |
There was a problem hiding this comment.
Please, keep a separate call to this method, so it easier to substitute in GraalVM: https://github.com/quarkusio/quarkus/blob/ff457754943c36a620102571f854432deb41dbf7/core/runtime/src/main/java/io/quarkus/runtime/configuration/Substitutions.java#L60
We need to remove any references to MethodHandles for native compilation. We could substitute the method loadClass(final Class<?> parent, final String className, final byte[] classBytes), but that means that we need to keep the body in sync between the implementation and substitution, since we still want to call loadClass.
There was a problem hiding this comment.
Because I needed to pass parent through to the defineClass call, the parameter lists become the same. So to keep the methods separate, one of the methods needs to change name. Any suggestions?
There was a problem hiding this comment.
defineClass instead of the second loadClass method?
There was a problem hiding this comment.
Yes, just call it defineClass.
There was a problem hiding this comment.
I made this change when I did the rebase on master
|
@radcortez do you mean all PRs need to be opened against master and you will rebase the mpconfig20 against master? Just to be clear this change is needed for MP Config 2.0 support for Open Liberty. |
Signed-off-by: tevans <tevans@uk.ibm.com>
|
@radcortez sure, I haven't had a chance to do anything with this PR yet today ... I have no idea why github thinks I requested a review 2 hours ago?! |
|
Oh... I thought you did something to it, because I got the review notification, plus the PR had some weird history. |
tevans78
force-pushed
the
useAppClassLoader
branch
from
367c674 to
05ea349
Compare
|
@radcortez ready for re-review ;-) many thanks to @Azquelt for doing the rebase for me. |
Signed-off-by: tevans tevans@uk.ibm.com
fixes #418