Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse JsonReader from the typesafe client by the dynamic client #843

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

jmartisk
Copy link
Member

@jmartisk jmartisk commented Jun 8, 2021

  • This only addresses the usage of @Name for now. @DateFormat etc need to be added to the common code IIUC.
  • This removes the JSON-B dependency from the client
  • While this makes some dynamic client bits depend on stuff from packages named typesafe, I'd perhaps prefer not reorganizing the packages now (like moving that stuff into something called "common"), that will be done with Rebase typesafe client on the dynamic client #725

But most importantly:

  • I find it a bit odd that the client code does not make use of the @Name annotation when parsing a returned object, so when client and server share the same model class, and that class contains a @Name("b") String a, then the client has to request a:b (an alias) to properly retrieve and parse the field. @t1 says it's by design, I'm not quite sure. See DynamicClientTest#testRenamedField. @phillip-kruger WDYT?

@phillip-kruger
Copy link
Member

phillip-kruger commented Jun 8, 2021

Yea it should be the same as the server. Although we can keep support for a:b in the client.

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillip-kruger phillip-kruger added this to the 1.2.5 milestone Jun 8, 2021
@phillip-kruger phillip-kruger merged commit 14b01d2 into smallrye:main Jun 8, 2021
@jmartisk jmartisk deleted the main-issue-839 branch June 11, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants