Reuse JsonReader from the typesafe client by the dynamic client #843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Name
for now.@DateFormat
etc need to be added to the common code IIUC.typesafe
, I'd perhaps prefer not reorganizing the packages now (like moving that stuff into something called "common"), that will be done with Rebase typesafe client on the dynamic client #725But most importantly:
@Name
annotation when parsing a returned object, so when client and server share the same model class, and that class contains a@Name("b") String a
, then the client has to requesta:b
(an alias) to properly retrieve and parse the field. @t1 says it's by design, I'm not quite sure. SeeDynamicClientTest#testRenamedField
. @phillip-kruger WDYT?