Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for String-based queries in the dynamic client #847

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

jmartisk
Copy link
Member

@jmartisk jmartisk commented Jun 8, 2021

Fixes #806

@@ -14,12 +14,18 @@

Response executeSync(Request request) throws ExecutionException, InterruptedException;

Response executeSync(String request) throws ExecutionException, InterruptedException;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not here also have a way to pass in vars and operationName ? (overload the method as they are optional). Same with the other methods.

@phillip-kruger phillip-kruger added this to the 1.2.5 milestone Jun 9, 2021
@phillip-kruger phillip-kruger merged commit 92d8749 into smallrye:main Jun 9, 2021
@jmartisk jmartisk deleted the issue-806 branch June 9, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using string-based queries in the dynamic client
2 participants