Merge pull request #770 from smallrye/internal/parallel-build

Parallel tests execution

CONTRIBUTING.md

@@ -51,8 +51,8 @@ We even accept pull requests just containing tests or documentation.
 If you have not done so on this machine, you need to:
 
 * Install Git and configure your GitHub access
-* Install Java SDK (OpenJDK recommended)
-* Install Apache Maven
+* Install Java SDK (OpenJDK recommended, see https://adoptium.net/)
+* Install Apache Maven (or use the `mvnw` wrapper scripts instead of `mvn`)
 
 ## Build
 
@@ -67,6 +67,21 @@ mvn clean install
 # Wait... success!
 ```
 
+### Faster builds
+
+Tests account for the majority of the build time.
+
+There are 2 Maven profiles that you can activate to speed up the build of the Mutiny core library (in `implementation/`):
+
+- `-Pskip-rs-tck` to avoid running the Reactive Streams TCK
+- `-Pparallel-tests` to run the JUnit5 tests in parallel
+
+The 2 profiles can be activated at the same time if you want to benefit from parallel tests and skip the Reactive Streams TCK.
+This is mostly useful to have fast development feedback loops.
+
+Note that parallel tests are not activated by default (yet) because some tests may randomly fail if your system is under load, or if it has constrained resources.
+The Reactive Streams TCK is a good example as it uses some time-sensitive checks.
+
 ## The small print
 
 This project is an open source project, please act responsibly, be nice, polite and enjoy!

implementation/pom.xml

@@ -175,5 +175,27 @@
  </plugins>
  </build>
  </profile>
+ <profile>
+ <id>parallel-tests</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <properties>
+ <configurationParameters>
+ junit.jupiter.extensions.autodetection.enabled=true
+ junit.jupiter.testinstance.lifecycle.default = per_class
+ junit.jupiter.execution.parallel.enabled = true
+ junit.jupiter.execution.parallel.mode.default = same_thread
+ junit.jupiter.execution.parallel.mode.classes.default = concurrent
+ </configurationParameters>
+ </properties>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
  </profiles>
 </project>

implementation/src/main/java/io/smallrye/mutiny/groups/MultiTimePeriod.java

@@ -14,7 +14,7 @@
 public class MultiTimePeriod {
 
  private Duration initialDelay;
- private ScheduledExecutorService executor = Infrastructure.getDefaultWorkerPool();
+ private ScheduledExecutorService executor;
 
  @CheckReturnValue
  public MultiTimePeriod startingAfter(Duration duration) {
@@ -31,10 +31,14 @@ public MultiTimePeriod onExecutor(ScheduledExecutorService executor) {
  @CheckReturnValue
  public Multi<Long> every(Duration duration) {
  validate(duration, "duration");
+ ScheduledExecutorService executorService = this.executor;
+ if (executorService == null) {
+ executorService = Infrastructure.getDefaultWorkerPool();
+ }
  if (initialDelay != null) {
- return Infrastructure.onMultiCreation(new IntervalMulti(initialDelay, duration, executor));
+ return Infrastructure.onMultiCreation(new IntervalMulti(initialDelay, duration, executorService));
  } else {
- return Infrastructure.onMultiCreation(new IntervalMulti(duration, executor));
+ return Infrastructure.onMultiCreation(new IntervalMulti(duration, executorService));
  }
  }
 

implementation/src/test/java/io/smallrye/mutiny/BugReproducersTest.java

@@ -16,10 +16,14 @@
 
 import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.helpers.test.AssertSubscriber;
 import io.smallrye.mutiny.infrastructure.Infrastructure;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 class BugReproducersTest {
 
  @RepeatedTest(100)

implementation/src/test/java/io/smallrye/mutiny/groups/MultiBroadcastTest.java

@@ -8,11 +8,15 @@
 import java.util.concurrent.atomic.AtomicBoolean;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.Multi;
 import io.smallrye.mutiny.helpers.MultiEmitterProcessor;
 import io.smallrye.mutiny.helpers.test.AssertSubscriber;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 public class MultiBroadcastTest {
 
  @Test

implementation/src/test/java/io/smallrye/mutiny/groups/MultiDisjointTest.java

@@ -9,13 +9,17 @@
 import java.util.concurrent.atomic.AtomicBoolean;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.reactivex.Flowable;
 import io.smallrye.mutiny.Multi;
 import io.smallrye.mutiny.Uni;
 import io.smallrye.mutiny.helpers.test.AssertSubscriber;
+import junit5.support.InfrastructureResource;
 
 @SuppressWarnings("ConstantConditions")
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 public class MultiDisjointTest {
 
  @Test

implementation/src/test/java/io/smallrye/mutiny/groups/UniMemoizeTest.java

@@ -16,6 +16,8 @@
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.reactivex.processors.UnicastProcessor;
 import io.smallrye.mutiny.Multi;
@@ -28,8 +30,10 @@
 import io.smallrye.mutiny.subscription.Cancellable;
 import io.smallrye.mutiny.subscription.UniSubscriber;
 import io.smallrye.mutiny.subscription.UniSubscription;
+import junit5.support.InfrastructureResource;
 
 @DisplayName("Tests for the uni.memoize() group")
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 class UniMemoizeTest {
 
  private static void race(Runnable candidate1, Runnable candidate2, Executor s) {

implementation/src/test/java/io/smallrye/mutiny/groups/UniOnFailureRetryTest.java

@@ -15,10 +15,14 @@
 import java.util.function.Predicate;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.Multi;
 import io.smallrye.mutiny.Uni;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 public class UniOnFailureRetryTest {
  @Test
  public void testFailureWithPredicateException() {

implementation/src/test/java/io/smallrye/mutiny/groups/UniSubscriberTest.java

@@ -11,10 +11,14 @@
 import java.util.concurrent.atomic.AtomicReference;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.Uni;
 import io.smallrye.mutiny.subscription.Cancellable;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 public class UniSubscriberTest {
 
  @Test

implementation/src/test/java/io/smallrye/mutiny/helpers/BlockingIterableTest.java

@@ -22,14 +22,18 @@
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 import org.reactivestreams.Subscriber;
 
 import io.smallrye.mutiny.Multi;
 import io.smallrye.mutiny.helpers.queues.SpscArrayQueue;
 import io.smallrye.mutiny.infrastructure.Infrastructure;
 import io.smallrye.mutiny.operators.AbstractMulti;
 import io.smallrye.mutiny.subscription.BackPressureFailure;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 public class BlockingIterableTest {
 
  @Test
@@ -244,6 +248,7 @@ public void testOverflow() {
  }
 
  @Nested
+ @ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ_WRITE)
  class ThreadBlockingTest {
 
  @BeforeEach

implementation/src/test/java/io/smallrye/mutiny/helpers/test/AssertSubscriberTest.java

@@ -12,14 +12,18 @@
 
 import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 import org.reactivestreams.Subscription;
 
 import io.smallrye.mutiny.Multi;
 import io.smallrye.mutiny.TestException;
 import io.smallrye.mutiny.TimeoutException;
 import io.smallrye.mutiny.Uni;
 import io.smallrye.mutiny.infrastructure.Infrastructure;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 public class AssertSubscriberTest {
 
  private final Duration SMALL = Duration.ofMillis(200);

implementation/src/test/java/io/smallrye/mutiny/helpers/test/UniAssertSubscriberTest.java

@@ -10,12 +10,16 @@
 import java.util.function.Consumer;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.TestException;
 import io.smallrye.mutiny.TimeoutException;
 import io.smallrye.mutiny.Uni;
 import io.smallrye.mutiny.subscription.UniEmitter;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 class UniAssertSubscriberTest {
 
  @Test

implementation/src/test/java/io/smallrye/mutiny/infrastructure/CallbackDecoratorTest.java

@@ -7,9 +7,13 @@
 
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.tuples.Functions;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ_WRITE)
 public class CallbackDecoratorTest {
 
  Runnable runnable = () -> {

implementation/src/test/java/io/smallrye/mutiny/infrastructure/DroppedExceptionsTest.java

@@ -11,10 +11,14 @@
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.Uni;
 import io.smallrye.mutiny.subscription.Cancellable;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ_WRITE)
 public class DroppedExceptionsTest {
 
  private static final PrintStream systemErr = System.err;

implementation/src/test/java/io/smallrye/mutiny/infrastructure/MutinySchedulerTest.java

@@ -15,11 +15,15 @@
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.Multi;
 import io.smallrye.mutiny.Uni;
+import junit5.support.InfrastructureResource;
 
 @SuppressWarnings("ConstantConditions")
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ_WRITE)
 public class MutinySchedulerTest {
 
  @BeforeAll

implementation/src/test/java/io/smallrye/mutiny/infrastructure/UniInterceptorTest.java

@@ -4,13 +4,17 @@
 
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.Uni;
 import io.smallrye.mutiny.operators.AbstractUni;
 import io.smallrye.mutiny.subscription.UniDelegatingSubscriber;
 import io.smallrye.mutiny.subscription.UniSubscriber;
 import io.smallrye.mutiny.subscription.UniSubscription;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ_WRITE)
 public class UniInterceptorTest {
 
  @AfterEach

implementation/src/test/java/io/smallrye/mutiny/operators/MultiCreateFromTimePeriodTest.java

@@ -12,11 +12,15 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.Multi;
 import io.smallrye.mutiny.helpers.test.AssertSubscriber;
 import io.smallrye.mutiny.subscription.BackPressureFailure;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 public class MultiCreateFromTimePeriodTest {
 
  private ScheduledExecutorService executor;

implementation/src/test/java/io/smallrye/mutiny/operators/MultiDistinctTest.java

@@ -13,6 +13,8 @@
 import java.util.function.Consumer;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 import org.reactivestreams.Subscriber;
 import org.reactivestreams.Subscription;
 
@@ -22,8 +24,10 @@
 import io.smallrye.mutiny.helpers.spies.Spy;
 import io.smallrye.mutiny.helpers.test.AssertSubscriber;
 import io.smallrye.mutiny.subscription.MultiEmitter;
+import junit5.support.InfrastructureResource;
 
 @SuppressWarnings("ConstantConditions")
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 public class MultiDistinctTest {
 
  @Test

implementation/src/test/java/io/smallrye/mutiny/operators/MultiGroupTest.java

@@ -18,6 +18,8 @@
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 import org.reactivestreams.Subscriber;
 import org.reactivestreams.Subscription;
 
@@ -33,7 +35,9 @@
 import io.smallrye.mutiny.subscription.MultiEmitter;
 import io.smallrye.mutiny.subscription.MultiSubscriber;
 import io.smallrye.mutiny.test.Mocks;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ_WRITE)
 public class MultiGroupTest {
 
  @AfterEach

implementation/src/test/java/io/smallrye/mutiny/operators/MultiIfNoItemTest.java

@@ -12,13 +12,17 @@
 
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
+import org.junit.jupiter.api.parallel.ResourceAccessMode;
+import org.junit.jupiter.api.parallel.ResourceLock;
 
 import io.smallrye.mutiny.Multi;
 import io.smallrye.mutiny.TestException;
 import io.smallrye.mutiny.TimeoutException;
 import io.smallrye.mutiny.helpers.ParameterValidation;
 import io.smallrye.mutiny.helpers.test.AssertSubscriber;
+import junit5.support.InfrastructureResource;
 
+@ResourceLock(value = InfrastructureResource.NAME, mode = ResourceAccessMode.READ)
 public class MultiIfNoItemTest {
 
  @Test