Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exponentialBackoffExpireAt should start at 0 #1453

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

manofthepeace
Copy link
Contributor

Fixes #1447

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #1453 (33fba4f) into main (7408703) will decrease coverage by 0.18%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1453      +/-   ##
============================================
- Coverage     89.38%   89.21%   -0.18%     
+ Complexity     3367     3361       -6     
============================================
  Files           459      459              
  Lines         13402    13402              
  Branches       1641     1641              
============================================
- Hits          11980    11956      -24     
- Misses          792      814      +22     
- Partials        630      632       +2     
Files Coverage Δ
...io/smallrye/mutiny/helpers/ExponentialBackoff.java 82.14% <100.00%> (ø)

... and 9 files with indirect coverage changes

Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Could you please add a test as well? UniOnFailureRetryTest is a good place for that.

@jponge jponge added the bug Something isn't working label Dec 4, 2023
@jponge jponge added this to the 2.5.2 milestone Dec 4, 2023
@manofthepeace
Copy link
Contributor Author

Hopefully the timing wont make it flaky. I tried with lower values but it made it flaky.

@jponge
Copy link
Member

jponge commented Dec 4, 2023

Looks like it worked in CI (great for catching flaky tests!) but you can always increase values if you think it's at risk for failing

@manofthepeace
Copy link
Contributor Author

Seems ok with these values. Worse case the solution will be to bump the values with the rule that the initial wait needs to be under the expiry, and the subsequent backoff would be above.

@jponge jponge merged commit 9064ba0 into smallrye:main Dec 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expireIn/At backoff starts with 2^1 factor instead of 2^0
2 participants