Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce tests flakiness, especially in CI / constrained environments #769

Merged
merged 7 commits into from
Dec 7, 2021

Conversation

jponge
Copy link
Member

@jponge jponge commented Nov 30, 2021

Work to reduce flakiness of the tests suite.

This forces more tests cases to limit their side-effects within the same class.
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #769 (007b15d) into main (4bc9baf) will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #769      +/-   ##
============================================
+ Coverage     89.81%   90.26%   +0.44%     
- Complexity     2999     3018      +19     
============================================
  Files           377      377              
  Lines         11880    11883       +3     
  Branches       1496     1499       +3     
============================================
+ Hits          10670    10726      +56     
+ Misses          614      587      -27     
+ Partials        596      570      -26     
Impacted Files Coverage Δ
...smallrye/mutiny/helpers/test/AssertSubscriber.java 89.47% <0.00%> (-0.76%) ⬇️
...c/main/kotlin/io/smallrye/mutiny/coroutines/Uni.kt 100.00% <0.00%> (ø)
...iny/operators/multi/builders/BaseMultiEmitter.java 83.33% <0.00%> (ø)
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 86.15% <0.00%> (+0.61%) ⬆️
...subscription/SwitchableSubscriptionSubscriber.java 97.54% <0.00%> (+0.81%) ⬆️
...java/io/smallrye/mutiny/helpers/Subscriptions.java 81.76% <0.00%> (+1.10%) ⬆️
...allrye/mutiny/operators/uni/UniAndCombination.java 89.53% <0.00%> (+1.16%) ⬆️
...tiny/operators/multi/MultiBufferWithTimeoutOp.java 74.78% <0.00%> (+1.68%) ⬆️
...io/smallrye/mutiny/operators/uni/UniMemoizeOp.java 95.04% <0.00%> (+1.98%) ⬆️
...erators/multi/builders/SerializedMultiEmitter.java 83.54% <0.00%> (+2.53%) ⬆️
... and 5 more

@jponge jponge force-pushed the internal/fix-infra-test-flakyness branch 4 times, most recently from a48e3fe to 3fc723d Compare December 1, 2021 17:13
@jponge jponge mentioned this pull request Dec 1, 2021
@jponge jponge changed the title [do not merge] Tests flakiness explorations Reduce tests flakiness, especially in CI / constrained environments Dec 1, 2021
@jponge jponge added ci/cd/build CI/CD pipeline and build technical-debt Technical debt reduction labels Dec 1, 2021
@jponge jponge added this to the 1.3.0 milestone Dec 1, 2021
@jponge jponge marked this pull request as ready for review December 1, 2021 19:23
@jponge
Copy link
Member Author

jponge commented Dec 1, 2021

I've tested multiple times on macOS, Github actions and Linux on WSL. Seems ok, I encourage reviewers to check locally as well.

@jponge
Copy link
Member Author

jponge commented Dec 7, 2021

Merging this one, it's been quite reliable in many recent CI runs.

@jponge jponge merged commit 6a72b91 into main Dec 7, 2021
@jponge jponge deleted the internal/fix-infra-test-flakyness branch December 7, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd/build CI/CD pipeline and build technical-debt Technical debt reduction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants