Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore synthetic JAX-RS resource classes by default #1096

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Ignore synthetic JAX-RS resource classes by default #1096

merged 2 commits into from
Mar 17, 2022

Conversation

MikeEdgar
Copy link
Member

Fixes #1095

@MikeEdgar MikeEdgar added this to the 2.1.22 milestone Mar 17, 2022
@MikeEdgar MikeEdgar force-pushed the 1095_ignore_synthetic_classes branch from 1a20954 to 70e6cfe Compare March 17, 2022 10:23
@MikeEdgar MikeEdgar force-pushed the 1095_ignore_synthetic_classes branch from 70e6cfe to f3a6b25 Compare March 17, 2022 10:29
@MikeEdgar MikeEdgar mentioned this pull request Mar 17, 2022
Closed
@phillip-kruger
Copy link
Member

I think the problem is for some synthetic classes we do not want this. Like panache-rest, where the server side is generated ? Not sure if that applies here, can you double check ?

@MikeEdgar
Copy link
Member Author

Like panache-rest, where the server side is generated ?

Ah, maybe that's where checking for @RegisterRestClient comes back into the picture.

@phillip-kruger
Copy link
Member

ok are we already doing that ? Maybe add a test for that scenario ? (class without @RegisterRestClient)

@MikeEdgar
Copy link
Member Author

We are not, due to some previous issues. I'm checking what a Panache REST resource looks like as well.

@phillip-kruger
Copy link
Member

Ok cool

@MikeEdgar
Copy link
Member Author

@phillip-kruger updated, please have another look. We need a way to put the source code for the test index in the project. Maybe we should add another module that is a test dependency of the others that builds a Quarkus app?

phillip-kruger
phillip-kruger approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeEdgar MikeEdgar mentioned this pull request Mar 17, 2022
Closed
@MikeEdgar MikeEdgar merged commit ce2d531 into smallrye:main Mar 17, 2022
@MikeEdgar MikeEdgar deleted the 1095_ignore_synthetic_classes branch March 17, 2022 17:48
MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this pull request Mar 11, 2023
@MikeEdgar
Make testsuite/data a Quarkus app, include indexed classes from small…
e9fc850 
…rye#1096

Fixes smallrye#1098

Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this pull request Mar 11, 2023
@MikeEdgar
Make testsuite/data a Quarkus app, include indexed classes from small…
2bc96af 
…rye#1096

Fixes smallrye#1098

Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this pull request Mar 11, 2023
@MikeEdgar
Make testsuite/data a Quarkus app, include indexed classes from small…
88d8836 
…rye#1096

Fixes smallrye#1098

Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this pull request Mar 14, 2023
@MikeEdgar
Make testsuite/data a Quarkus app, include indexed classes from small…
c7f9548 
…rye#1096

Fixes smallrye#1098

Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this pull request Mar 14, 2023
@MikeEdgar
Make testsuite/data a Quarkus app, include indexed classes from small…
8808fd3 
…rye#1096

Fixes smallrye#1098

Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this pull request Mar 15, 2023
@MikeEdgar
Make testsuite/data a Quarkus app, include indexed classes from small…
e5b88c9 
…rye#1096

Fixes smallrye#1098

Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this pull request Mar 18, 2023
@MikeEdgar
Make testsuite/data a Quarkus app, include indexed classes from small…
0c48216 
…rye#1096

Fixes smallrye#1098

Signed-off-by: Michael Edgar <michael@xlate.io>
phillip-kruger added a commit that referenced this pull request Mar 19, 2023
@phillip-kruger
Merge pull request #1401 from MikeEdgar/issue-1098
09b2f6f 
Make testsuite/data a Quarkus app, include indexed classes from #1096
@MikeEdgar MikeEdgar mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.22
Development

Successfully merging this pull request may close these issues.

Synthetic classes not ignored
2 participants
@MikeEdgar @phillip-kruger