Bean validation spec #1145
Merged
Bean validation spec #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were a few different options for making the scanning optional, so do check you're happy with that part. |
MikeEdgar
reviewed
May 28, 2022
core/src/main/java/io/smallrye/openapi/runtime/scanner/spi/AbstractParameterProcessor.java
Show resolved
Hide resolved
core/src/main/java/io/smallrye/openapi/runtime/scanner/dataobject/BeanValidationScanner.java
Show resolved
Hide resolved
.../src/main/java/io/smallrye/openapi/runtime/scanner/dataobject/AnnotationTargetProcessor.java
Show resolved
Hide resolved
|
I've made updates in response to the review comments. |
Respect the new config property added to the spec for bean validation annotation scanning.
Rather than constraints which apply only to the default group, to match proposed spec.
Use an exclusive range for Positive and Negative constraints
Use consistent patterns for code which is run only if we have a bean validation scanner.
MikeEdgar
force-pushed
the
bean-validation-spec
branch
from
a5365ea to
fae1c28
Compare
MikeEdgar
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the bean validation annotation scanning to match the spec update in eclipse/microprofile-open-api#531
The changes needed were:
@Positiveand@Negative