Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jandex 3.0.0 #1229

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Upgrade to Jandex 3.0.0 #1229

merged 1 commit into from
Sep 5, 2022

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Aug 26, 2022

Submitting as draft because this needs discussion on release coordination (I guess).

@MikeEdgar
Copy link
Member

Jandex is managed by the smallrye-parent pom currently. Will that be continued going forward?

@Ladicek
Copy link
Contributor Author

Ladicek commented Aug 29, 2022

Frankly, I just don't like how the SmallRye parent manages (or not) some versions. To me, it feels like a big dump of random stuff that is only updated when someone remembers and there's no coordination around it. In SmallRye Fault Tolerance, I don't even use it (I use smallrye-build-parent).

This is a relatively big/important change that requires coordination -- adding the parent POM to the mix would just make it worse. I propose we replace Jandex 2.x with Jandex 3.0 in the parent POM when things settle.

@Ladicek
Copy link
Contributor Author

Ladicek commented Aug 29, 2022

I also just noticed that SmallRye OpenAPI uses the Type hierarchy on a few places (TypeProcessor, TypeResolver). This code will likely have to be updated to deal with type variable references. In general, code that handles UnresolvedTypeVariable or Type.Kind.UNRESOLVED_TYPE_VARIABLE likely needs to be updated. I don't really understand how that code works, so I'll refrain from attempting to change it myself. Just letting you know.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@MikeEdgar MikeEdgar marked this pull request as ready for review September 5, 2022 11:35
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - ignoring the code coverage check since they're just proxy methods and aren't being used (yet) anyway.

@MikeEdgar MikeEdgar added this to the 3.1.0 milestone Sep 5, 2022
@MikeEdgar MikeEdgar merged commit faadf58 into smallrye:main Sep 5, 2022
@Ladicek Ladicek deleted the jandex3 branch September 5, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants