Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan Kotlin nullability annotations #1253

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Scan Kotlin nullability annotations #1253

merged 2 commits into from
Sep 8, 2022

Conversation

MikeEdgar
Copy link
Member

Fixes #716

@MikeEdgar MikeEdgar added the backport/2.x Issue pending backport to the 2.x series label Sep 8, 2022
@MikeEdgar MikeEdgar added this to the 3.1.0 milestone Sep 8, 2022
@MikeEdgar
Scan Kotlin nullability annotations
c50f6f2 
Signed-off-by: Michael Edgar <michael@xlate.io>
@MikeEdgar
Remove unused method parameter, merge conditions
db9b8e0 
Signed-off-by: Michael Edgar <michael@xlate.io>
@MikeEdgar MikeEdgar marked this pull request as ready for review September 8, 2022 11:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MikeEdgar MikeEdgar merged commit 6770032 into smallrye:main Sep 8, 2022
@MikeEdgar MikeEdgar deleted the issue-716 branch September 8, 2022 11:50
@asafalima
Copy link

Hi @MikeEdgar can we please create a new release? we really need this fix :)

@MikeEdgar
Copy link
Member Author

can we please create a new release? we really need this fix :)

I'll look to get one put together in the next few days.

@asafalima
Copy link

can we please create a new release? we really need this fix :)

I'll look to get one put together in the next few days.

Thank you for your quick response @MikeEdgar.
@DmitriyO FYI

@asafalima
Copy link

can we please create a new release? we really need this fix :)

I'll look to get one put together in the next few days.

Hi @MikeEdgar , any new regarding the new release?

@MikeEdgar MikeEdgar mentioned this pull request Oct 14, 2022
Merged
@MikeEdgar MikeEdgar removed the backport/2.x Issue pending backport to the 2.x series label Oct 14, 2022
@MikeEdgar
Copy link
Member Author

@asafalima - release 2.3.1 is out! It should also be updated in Quarkus shortly if all goes well - quarkusio/quarkus#28611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Support kotlin nullable/non-nullable types as if explicitly set @Schema(required=true/false)
3 participants
@MikeEdgar @asafalima @phillip-kruger