-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer parameter order from @Parameters
annotation
#1274
Conversation
{ | ||
"$ref": "#/components/parameters/pathParam2" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been hidden all along (line 32)
Lines 22 to 34 in 9804d39
@GET | |
@Path(value = "/two") | |
@Parameter(name = "pathParam1", style = ParameterStyle.SIMPLE) | |
@Parameter(ref = "pathParam2") | |
@Parameter(ref = "queryParam1", name = "queryParamOne") | |
@Parameter(in = ParameterIn.COOKIE, description = "Ignored: missing key attributes") | |
@Parameter(in = ParameterIn.DEFAULT, description = "Ignored: missing key attributes") | |
@Parameter(in = ParameterIn.HEADER, description = "Ignored: missing key attributes") | |
@Parameter(in = ParameterIn.PATH, description = "Ignored: missing key attributes") | |
String exampleEndpoint2(@PathParam(value = "pathParam1") String pathParam1, | |
@Parameter(hidden = true) @PathParam(value = "pathParam2") String pathParam2) { | |
return null; | |
} |
5c1f463
to
ccb6f53
Compare
Closes smallrye#1165 Signed-off-by: Michael Edgar <michael@xlate.io>
Signed-off-by: Michael Edgar <michael@xlate.io>
ccb6f53
to
e932512
Compare
Kudos, SonarCloud Quality Gate passed! |
@phillip-kruger , please take a look when you get a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1165
Signed-off-by: Michael Edgar michael@xlate.io