Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the order for server configuration #1323

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented Nov 29, 2022

@gsmet
Copy link
Contributor Author

gsmet commented Nov 29, 2022

I'm not very accustomed to this project but this change looks like a good thing to me. Let me know what you think.

(And hopefully, the TCKs will pass...)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.2% 84.2% Coverage
0.0% 0.0% Duplication

Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gsmet. Mind if we keep this for 3.1.1? We just had 3.1.0 certified for the spec release and I'd like to keep the core modules unchanged if possible. We can do 3.1.1 immediately after.

@MikeEdgar MikeEdgar added this to the 3.1.1 milestone Nov 29, 2022
@gsmet
Copy link
Contributor Author

gsmet commented Nov 29, 2022

Sure. Any chance you could also backport it to 2.x so that we get it in Quarkus before Quarkus 3?

I can prepare a specific PR if it doesn't apply cleanly (I don't know what's your backport process here).

@MikeEdgar MikeEdgar added the backport/2.x Issue pending backport to the 2.x series label Nov 29, 2022
@MikeEdgar
Copy link
Member

Yes, I'll backport it to 2.x. It's usually just a PR with a collection of cherry-picked commits from main.

@gsmet
Copy link
Contributor Author

gsmet commented Nov 29, 2022

Perfect, then. Thanks!

@MikeEdgar MikeEdgar merged commit 501f8e4 into smallrye:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/2.x Issue pending backport to the 2.x series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants