Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive path might start with . (dot) breaking inclusion/exclusion #206

Merged

Conversation

user667
Copy link

@user667 user667 commented Nov 5, 2019

Fixes #205

@user667 user667 force-pushed the 205-ArchiveUtil-fix-fqcn-determination branch from 69ea939 to d97341e Compare November 5, 2019 19:55
@user667 user667 force-pushed the 205-ArchiveUtil-fix-fqcn-determination branch from d97341e to 7d0fd64 Compare November 5, 2019 20:01
@user667
Copy link
Author

user667 commented Nov 5, 2019

Updated PR: Changed fix so fqcn is sanitized before last . (dot) is removed and also applied formatting changes from formatter-maven-plugin.

Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@user667, this looks good. I made one comment on the approach to consider. Let me know your feedback on that.

@MikeEdgar MikeEdgar merged commit 49ac90d into smallrye:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArchiveUtil doesn't correctly include and exclude classes and packages
2 participants