Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LocalTime and OffsetTime #234

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

MikeEdgar
Copy link
Member

@MikeEdgar MikeEdgar commented Dec 17, 2019

Fixes #233

Add support for LocalTime and OffsetTime in TypeUtil. This includes a simple example as well as externalDocs for each (see the test JSON for the result). LocalTime uses format "local-time", whereas OffsetTime uses "time", which seemed in alignment with the OAS 3 spec section on data types. Each use a description and link for externalDocs that matches that of date and date-time in the spec as well.

This also switches TypeWithFormat to a builder pattern to allow extension of default schema attributes without additional constructor permutations.

@EricWittmann EricWittmann merged commit 60f623f into smallrye:master Dec 19, 2019
@MikeEdgar MikeEdgar deleted the 233_time_types branch December 20, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LocalTime format as a String (JDK8)
2 participants