Add Extension parsing method to AnnotationScannerExtension #250
Conversation
- Add tests to require that Jackson library is not necessary for annotation scanning when providing custom implementation of `AnnotationScannerExtension#parseExtension`
MikeEdgar
force-pushed
the
245_extension_reader
branch
from
db7742f to
b912b1d
Compare
| * @param key the name of the extension property | ||
| * @param value the string value of the extension | ||
| */ | ||
| default Object parseExtension(String key, String value) { |
There was a problem hiding this comment.
@tjquinno, please let me know if this method definition will cover what you need to parse extensions.
There was a problem hiding this comment.
Thanks @MikeEdgar . I think the answer is "yes." I had to shift gears to some other things briefly so I'm not in a position right now to try this (probably first thing next week). But I think it looks as if it'll work.
There was a problem hiding this comment.
@MikeEdgar Just FYI, I'm using a local build of the latest SmallRye master (with this PR) and I see my AnnotationScannerExtension parseExtension method being invoked as expected. Thanks again.
There was a problem hiding this comment.
@tjquinno - very good, glad to hear that. I expect there will be a release in the next few days.
|
@MikeEdgar Appreciate the very fast turnaround on this. Is there somewhere I can look to see about the plans and timing for the next release (which would presumably include this and other changes)? Thanks. |
|
@tjquinno - minor releases are typically as needed. @kenfinnigan, @EricWittmann, @msavy - I think we are at a good point to tag and release. Any objections? |
|
Makes sense to me -- quite a bit of stuff gone in recent days alone!
On Tue, 4 Feb 2020, 22:34 Michael Edgar, <notifications@github.com> wrote:
...
|
|
No objections. |
|
@kenfinnigan - please tag/release smallrye-open-api when you get a chance. Thanks |
|
As we're using jakarta dependencies now, does it require a version bump to 1.3.x? |
|
I am OK with bumping the minor version, but I think it should be 1.2.x. Does it matter if the major/minor differs from the upstream MP version? |
|
Sorry, I did mean 1.2.x. I saw 1.1.20 and somehow read 1.2.x instead |
Fixes #245
annotation scanning when providing custom implementation of
AnnotationScannerExtension#parseExtensionExceptionMappersearch to eliminate Sonar "bugs"@Testannotation with JUnit annotation inExceptionMapperScanTests