[Bug]: step-ca does not detect when it's not in an interactive shell, sends escape codes for colours regardless

[cricalix]

Steps to Reproduce

Run step-ca docker image on something like a Synology NAS, which provides a web UI to review the logs.

Your Environment

• OS - Synology host, Docker image pulled as :latest on 2023-09-23
• step-ca Version - 24.2

Expected Behavior

step-ca detects that stdout is not interactive, strips colour codes from output.

Actual Behavior

step-ca does not detect that stdout is not interactive, includes colour codes, making logs very hard to read

Additional Context

I can work around the problem by setting up the NAS with SSH and using docker logs, but it'd still be nice if the step-ca binary accepted an environment variable to control emitting colours; I could then configure the docker env variables to set that variable.

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[maraino]

Hi @cricalix, I'm not able to reproduce this, on my docker the terminal is properly NOT detected and colors are disabled, but I've added support for the NO_COLOR environment variable here #1559

[maraino]

Fixed by #1559. Now the environment variable NO_COLOR can be set to disable colors.

[cricalix]

Thank you @maraino . It's possible that Synology's docker integration is a bit weird, and pretends to be a tty, but with NO_COLOR support I can at least pass that through once the docker image gets your patch.

[maraino]

Thank you @maraino . It's possible that Synology's docker integration is a bit weird, and pretends to be a tty, but with NO_COLOR support I can at least pass that through once the docker image gets your patch.

It should be already in smallstep/step-ca:0.25.0