Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Expires header to CRL endpoint #1708

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Add Expires header to CRL endpoint #1708

merged 4 commits into from
Feb 15, 2024

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Feb 8, 2024

This implements the change from wireapp@659117c.

Besides that, it improves the test (coverage) for the CRL HTTP handler.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Feb 8, 2024
@hslatman hslatman requested review from a team and maraino February 8, 2024 14:09
@hslatman hslatman added this to the v0.25.3 milestone Feb 13, 2024
maraino
maraino requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 404 might be a better response.

api/crl.go Outdated Show resolved Hide resolved
@hslatman hslatman merged commit bb296c9 into master Feb 15, 2024
13 checks passed
@hslatman hslatman deleted the herman/csr-expires-header branch February 15, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

Assignees

@maraino maraino

Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hslatman @maraino