Add GetX509Signer method #1850
Merged
Add GetX509Signer method #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a method to the Authority type that returns the signer used to sign X509 certificates.
github-actions
bot
added
the
needs triage
hslatman
reviewed
May 16, 2024
authority/tls_test.go
Outdated
| @@ -418,7 +428,7 @@ ZYtQ9Ot36qc= | |||
| require.NoError(t, err) | |||
| testAuthority.db = &db.MockAuthDB{ | |||
| MStoreCertificate: func(crt *x509.Certificate) error { | |||
| sassert.Equals(t, crt.Subject.CommonName, "smallstep test") | |||
| assert.Equal(t, crt.Subject.CommonName, "smallstep test") | |||
There was a problem hiding this comment.
It's better to reverse the order of arguments for expected and actual, but not a blocker. I've been changing those whenever I saw them happening and felt like they didn't muddy the PRs I was working at the time.
There was a problem hiding this comment.
I know, but I've just find and replace everything with sassert 🙂
Fixed with 812ffd3
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
hslatman
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a method to the Authority type that returns the signer used to sign X509 certificates.