Add support for validities in templates #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades go.step.sm/crypto with a version that adds support for setting validity bounds in templates. It also adds support for these in the certificate modifiers. The priority for the validity bounds are: 1. Coming from flags. 2. Coming from the template. 3. Defaults.
github-actions
bot
added
the
needs triage
hslatman
reviewed
Jul 1, 2024
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
hslatman
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades go.step.sm/crypto with a version that adds support for setting validity bounds in templates. It also modifies the X.509 certificate modifiers to support them. SSH certificate modifiers should work without changes.
The priority for the validity bounds are:
Requires: