Handle the redirect-url flag #1350
Open
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets the proper redirect-url parameter in the defaults.json if the flag `--redirect-url` is given in the bootstrap command.
github-actions
bot
added
the
needs triage
dopey
reviewed
Jan 28, 2025
| @@ -219,6 +219,15 @@ func BootstrapTeamAuthority(ctx *cli.Context, team, teamAuthority string) error | |||
| apiEndpoint = u.String() | |||
| } | |||
|
|
|||
| // Get the --redirect-url flag, If passed, we will use this one event if the | |||
There was a problem hiding this comment.
Suggested change
| // Get the --redirect-url flag, If passed, we will use this one event if the | |
| // Get the --redirect-url flag, If passed, we will use this one even if the |
dopey
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit sets the proper redirect-url parameter in the defaults.json if the flag
--redirect-urlis given in the bootstrap command.