Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniCA #40

Merged
merged 5 commits into from
Mar 16, 2022
Merged

MiniCA #40

merged 5 commits into from
Mar 16, 2022

Conversation

maraino
Copy link
Contributor

@maraino maraino commented Mar 15, 2022

Description

This PR implements a mini certificate authority.

When we're doing unit tests, having a simple CA to play with is generally useful. This new package adds a simple implementation for a CA.

@azazeal: This is something that I wanted to do for some time, and today had some time.
I will create something like this using this new package.

@maraino maraino marked this pull request as ready for review March 16, 2022 02:23
@maraino maraino requested a review from azazeal March 16, 2022 02:24
Copy link

@azazeal azazeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments I came up with after a quick read. Nice work!

minica/minica.go Outdated Show resolved Hide resolved
minica/minica.go Outdated Show resolved Hide resolved
minica/minica.go Outdated Show resolved Hide resolved
This commit also adds more documentation on which fields will be
automatically pupulated if they are not set.
@maraino maraino requested a review from azazeal March 16, 2022 18:42
minica/minica_test.go Outdated Show resolved Hide resolved
minica/minica_test.go Show resolved Hide resolved
@maraino maraino requested a review from azazeal March 16, 2022 19:34
@maraino maraino merged commit 7d0f0dd into master Mar 16, 2022
@maraino maraino deleted the minica branch March 16, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants