Refactor code generation #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azazeal
changed the title
azazeal
force-pushed
the
panos/majordomo
branch
from
9a7bdce
to
16f2938
Compare
|
A change like this might cause backward incompatibility problems between open-source step-ca and majordomo. Although we don't have EAB support, it might work. But we would need to test it. |
azazeal
force-pushed
the
panos/majordomo
branch
from
16f2938
to
f6adf0e
Compare
maraino
reviewed
Sep 5, 2023
azazeal
force-pushed
the
panos/majordomo
branch
from
31a5d45
to
866117d
Compare
maraino
requested changes
Sep 7, 2023
Co-authored-by: Mariano Cano <mariano@smallstep.com>
Co-authored-by: Mariano Cano <mariano@smallstep.com>
maraino
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the codebase in order to address our internal build issue. It additionally adds checks to the
Makefilethat ensure that code is generated via suitable versions ofprotoc-gen-goandprotoc-gen-go-grpc.