Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in readme #125

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix bug in readme #125

merged 3 commits into from
Sep 20, 2023

Conversation

issmirnov
Copy link
Contributor

The base64 command will auto add newlines after the column limit, which will break this script.

Patched the sample command so that this works correctly.

Name of feature: Readme bugfix

Pain or issue this feature alleviates:

Wrong command, breaks shell script. Linux newbies will struggle.

Why is this important to the project (if not answered above):

Simple, easy fix.

Is there documentation on how to use this feature? If so, where?

N/A

In what environments or workflows is this feature supported?

N/A

In what environments or workflows is this feature explicitly NOT supported (if any)?

N/A

Supporting links/other PRs/issues:

💔Thank you!

The base64 command will auto add newlines after the column limit, which will break this script.

Patched the sample command so that this works correctly.
@issmirnov issmirnov requested review from maraino and a team as code owners September 18, 2023 05:38
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Sep 18, 2023
@hslatman hslatman self-assigned this Sep 19, 2023
maraino
maraino previously approved these changes Sep 20, 2023
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing. I will change the command with step base64 which behaves the same way on different OSs.

README.md Outdated Show resolved Hide resolved
@maraino maraino merged commit 20634df into smallstep:master Sep 20, 2023
@issmirnov
Copy link
Contributor Author

Amazing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants