Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PDFObject.php #759

Closed
wants to merge 2 commits into from
Closed

Update PDFObject.php #759

wants to merge 2 commits into from

Conversation

doctorfox
Copy link

@doctorfox doctorfox commented Feb 4, 2025

Workaround for table data fields with newlines

Type of pull request

  • Bug fix (involves code and configuration changes)
  • New feature (involves code and configuration changes)
  • Documentation update
  • Something else

About

Checklist for code / configuration changes

See [CONTRIBUTING.md] for all essential information about contributing.

Workaround for table data fields with newlines
@k00ni
Copy link
Collaborator

k00ni commented Feb 5, 2025

Thank you for your PR.

Could you elaborate a bit what this fixes exactly?
Also, please check failing test cases and provide at least a unit or system test yourself to prove this fix works.

@k00ni k00ni added the stale needs decision label Feb 12, 2025
@doctorfox doctorfox closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants