feat: add expiresAt to joinGroup mutation response#30
Merged
takaokouji merged 2 commits intomainfrom Jan 2, 2026
Merged
Conversation
- Added expiresAt to Node type in schema - Updated joinGroupFunction to retrieve and return expiresAt from group metadata
takaokouji
added a commit
that referenced
this pull request
Jan 18, 2026
- Added AllowPreflightOptions rule (priority: 0) to allow OPTIONS requests - Fixed SingleHeader property name (name → Name) - Fixed TextTransformationType (UPPERCASE → NONE for method matching) - Ensures AppSync can return CORS headers for preflight requests This fixes the CORS error reported on Chromebook when connecting to production mesh v2 API (https://graphql.api.smalruby.app/graphql). WAF rules now properly handle: 1. Preflight OPTIONS requests from allowed origins (priority 0) 2. Regular POST requests from allowed origins (priority 1) 3. Block all other requests (default action) Tested on stg2 environment: - OPTIONS from https://smalruby.app → 200 + CORS headers ✅ - POST from https://smalruby.app → 200 + data ✅ - POST from https://example.com → 403 (blocked) ✅ Fixes #30 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
expiresAtfield to thejoinGroupmutation response. This allows joined members to receive the group's expiration time immediately upon joining, which is required for the new Mesh V2 status display in the Smalruby 3 menu bar.Changes
expiresAt: AWSDateTimeto theNodetype.joinGroupFunction.jsto retrieve the group'sexpiresAtfrom the context stash and include it in the response.join_group.graphqlfixture to include the new field.spec/requests/join_group_expires_at_spec.rbto verify the behavior.Verification
stg2environment.stg2(58 examples).standardrb) passed.