fix: include heartbeatIntervalSeconds in createGroup response#36
Merged
takaokouji merged 4 commits intomainfrom Jan 3, 2026
Merged
fix: include heartbeatIntervalSeconds in createGroup response#36takaokouji merged 4 commits intomainfrom
takaokouji merged 4 commits intomainfrom
Conversation
- Updated schema.graphql to add heartbeatIntervalSeconds to Group type - Updated createGroupIfNotExists.js to return heartbeatIntervalSeconds from environment variable
- Updated mesh-client.js to include heartbeatIntervalSeconds in mutations - Added sendMemberHeartbeat to mesh-client.js - Updated app.js to handle dynamic intervals and member heartbeats
…TIME_SECONDS - Added heartbeatIntervalSeconds to Group type and mutation examples in api-reference.md - Updated sequence diagrams and entity attributes in architecture.md - Renamed MESH_MAX_CONNECTION_TIME_MINUTES to MESH_MAX_CONNECTION_TIME_SECONDS in deployment.md and development.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing heartbeatIntervalSeconds field to the createGroup mutation response, ensuring the client can correctly adjust its heartbeat interval after creating a group.