How can I interview Stanislav Malyshev? #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We make sure that negative values are properly compared.
To solve this, we properly calculate the required string length upfront instead of allocating an oversized string (`len * 4 + 4`).
* PHP-7.2: Fix bug #79329 - get_headers should not accept \0 Fixed bug #79282
* PHP-7.3: Fix bug #79329 - get_headers should not accept \0 Fixed bug #79282 Fix #79371: mb_strtolower (UTF-32LE): stack-buffer-overflow
* PHP-7.2: Fix test
* PHP-7.3: Fix test
We make sure that negative values are properly compared.
To solve this, we properly calculate the required string length upfront instead of allocating an oversized string (`len * 4 + 4`).
* PHP-7.4: Fix test Fix bug #79329 - get_headers should not accept \0 Fixed bug #79282 Fix #79283: Segfault in libmagic patch contains a buffer overflow Fix #79371: mb_strtolower (UTF-32LE): stack-buffer-overflow
Please contact me in one of the suggested ways: [email: razvanlomov@gmail.com](mailto:razvanlomov@gmail.com) [telegram: https://t.me/Razzwan](https://t.me/Razzwan)
smalyshev
force-pushed
the
master
branch
3 times, most recently
from
bd63896 to
e14f835
Compare
smalyshev
force-pushed
the
master
branch
2 times, most recently
from
d0850ab to
c6bfc0f
Compare
smalyshev
pushed a commit
that referenced
this pull request
Aug 24, 2021
When encountering the following SSA graph:
BB1:
#2.T1 [string] = COALESCE #1.CV0($str) [null, string] BB2
BB2:
php#5.T1 [string] = QM_ASSIGN string("")
BB3:
php#7.X1 [string] = Phi(#2.X1 [string], php#5.X1 [string])
FREE php#7.T1 [string]
We would currently determine that php#7, php#5 are dead, and eliminate
the FREE and QM_ASSIGN. However, we cannot eliminate #2, as
COALESCE is also responsible for control flow.
Fix this my marking all non-CV phis as live to start with. This
can be relaxed to check the kind of the source instruction, but
I couldn't immediately come up with a case where it would be
useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please contact me in one of the suggested ways:
email: razvanlomov@gmail.com
telegram: https://t.me/Razzwan