Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node.js 10 requires additional include directory for internal includes #247

Closed
smanders opened this issue Oct 3, 2019 · 1 comment
Closed

node.js 10 requires additional include directory for internal includes #247

smanders opened this issue Oct 3, 2019 · 1 comment
Assignees
@smanders
Labels
bug
Milestone
19.11.1

Comments

@smanders
Copy link
Owner

smanders commented Oct 3, 2019

node.js 10 is currently available to use in externpro #219

however, an additional include directory is needed for "internal" includes, for example uv/include/uv/unix.h has

#include "uv/threadpool.h"

https://github.com/nodejs/node/blob/v10.16.0/deps/uv/include/uv/unix.h#L46

where previously in node.js 8 it had

#include "uv-threadpool.h"

https://github.com/nodejs/node/blob/v8.12.0/deps/uv/include/uv-unix.h#L45
@smanders smanders added the update label Oct 3, 2019
@smanders smanders added this to the current milestone Oct 3, 2019
@smanders smanders self-assigned this Oct 3, 2019
smanders pushed a commit that referenced this issue Oct 3, 2019
additional include directory for node 10
9fd9625 
issue #247
@smanders
Copy link
Owner Author

smanders commented Oct 3, 2019

completed with commit to dev branch referenced above

@smanders smanders closed this as completed Oct 3, 2019
@smanders smanders added bug and removed update labels Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smanders smanders

Labels
bug
Projects
None yet
Milestone
19.11.1
Development

No branches or pull requests
1 participant
@smanders