Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for the issue Timer Enhancement #37

Merged
merged 3 commits into from
Jun 29, 2021
Merged

PR for the issue Timer Enhancement #37

merged 3 commits into from
Jun 29, 2021

Conversation

SanjayDevTech
Copy link
Contributor

closes #22

  • Added Timer with circular progress bar
  • Rounded curve
  • Customisable widget

Screenshot_20210628-214755

@SanjayDevTech SanjayDevTech mentioned this pull request Jun 28, 2021
Closed
Procoder16
Procoder16 suggested changes Jun 28, 2021
View reviewed changes
Copy link

@Procoder16 Procoder16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the circular progress bar looks good but it would be better if you can change the colour combination of the circular progress bar from black/red to something according to the current theme

@SanjayDevTech
Copy link
Contributor Author

@Procoder16 Sure I'll change that

@SanjayDevTech
Copy link
Contributor Author

@Procoder16

  • Changed color from Black - Red to LightBlue - Blue

Screenshot_20210629-082953

Procoder16
Procoder16 approved these changes Jun 29, 2021
View reviewed changes
Copy link

@Procoder16 Procoder16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!!!
The changes to this issue now look nice to me.
Let's wait for the PA if they want anything else.

@SanjayDevTech
Copy link
Contributor Author

😄 Thanks

@smaranjitghose smaranjitghose merged commit 76e0b33 into smaranjitghose:main Jun 29, 2021
@smaranjitghose smaranjitghose added LGMSOC21 Let's Grow More Summer of Code 2021 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21.Points will be 30. labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Procoder16 Procoder16 Procoder16 approved these changes

@smaranjitghose smaranjitghose smaranjitghose approved these changes

Assignees
No one assigned
Labels
🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21.Points will be 30. LGMSOC21 Let's Grow More Summer of Code 2021 PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timer Enhancement
3 participants
@SanjayDevTech @smaranjitghose @Procoder16