Remove some unused headers #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These headers are not supported in mingw, but they do not seem to be used in any case.
|
utils/commons.h is a programming malpractice I should have removed a long time ago. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to compile this under windows using mingw, and some headers are not available there.
However, it seems like those headers are not used anywhere in the library anyway (at least it compiles fine on windows after i remove these).
At least for
pwd.handerr.hI'm fairly certain that they're not used anywhere since it would be weird to use them in this library, forsys/mman.hit would certainly be plausible they'd be used here, but I could not find anymmap/madvice/mlockcalls.