Skip to content

Commit

Permalink
Install pyright with dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
last-partizan committed May 20, 2022
1 parent fab19c7 commit 1f22b84
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
7 changes: 0 additions & 7 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,6 @@ def tests(session: PowerSession, coverage, pkg_specs):
# Important: do not surround the command into double quotes as in the shell !
# session.run('python', '-c', 'import os; os.chdir(\'./docs/\'); import %s' % pkg_name)

# Type checking is supported from python 3.7
if float(session.python) >= 3.7:
try:
session.run2("npm install -g pyright@1.1.247")
except CommandFailed:
print("Failed to install pyright, typing tests would be skipped")

# finally run all tests
if not coverage:
# install self so that it is recognized by pytest
Expand Down
5 changes: 2 additions & 3 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,9 @@ install_requires =
tests_require =
pytest
pytest_cases
# syrupy is used for snapshot testing with pyright,
# pyright must be installed separately, we're not using https://pypi.org/project/pyright/
# becouse it's just slow wrapper around node version.
# syrupy and pyright is used for testing type correctness.
syrupy>2;python_version>'3.6'
pyright;python_version>'3.6'
# for some reason these pytest dependencies were not declared in old versions of pytest
six;python_version<'3.6'
attr;python_version<'3.6'
Expand Down

0 comments on commit 1f22b84

Please sign in to comment.