fix color bug in svg template #20

texnofobix · 2021-09-18T00:15:12Z

Colors were not correctly being passed to the template. (All badges were returning green.)

Fixes #19

smarie · 2021-09-20T11:19:13Z

Thanks @texnofobix for spotting this stupid mistake !

It seems that the tests fail because of this fix, because of a caps issue in string comparison. Could you please have a look and fix the PR ?
Also since there was no explicit test for the issue, would you mind add one so that there is no regression in the future ?

Thanks in advance !

texnofobix · 2021-09-20T14:56:08Z

It seems strange changing an attribute's value broke the test. I will investigate and try making a test for it.

genbadge/tests/test_core.py

smarie · 2021-09-21T11:17:57Z

it seems that your new test did not have a parametrize. I tried to fix it from the web UI

texnofobix · 2021-09-21T12:00:34Z

Thanks for making the adjustment!

smarie · 2021-09-21T14:17:56Z

You're welcome. 1.0.6 shipping now

fix color bug in template

a7a1029

texnofobix mentioned this pull request Sep 18, 2021

local generator always shows green #19

Closed

texnofobix added 2 commits September 20, 2021 18:12

make all colors lowercase to match others

d06ec3c

add test case red

8c32bf7

smarie reviewed Sep 21, 2021

View reviewed changes

genbadge/tests/test_core.py Show resolved Hide resolved

fixed : missing parametrize

67ec6b5

smarie merged commit af38631 into smarie:main Sep 21, 2021

Provide feedback