use async fn for async trait
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. I'm still not 100% sure what this implies, but the reasoning behind the choice in the embedded environment does convince me: rust-embedded/embedded-hal#515 Could you please add your reasoning/this reasoning to explain the choice in a comment please, so people unaware are less confused? |
for readability A Send variant may be nice to use with Embassy's SendSpawner. However, embedded-hal-async traits don't have Send variants, so it's unlikely the that the drivers called in the impl's of this trait would have async fn's that return Send Futures. You probably don't want to be writing different frames to one LED device from multiple threads simultaneously anyway; that would require the driver to implement synchronization to avoid interleaving of separate frames, which would add a run time cost.
|
Oh nice find digging up the discussion in rust-embedded/embedded-hal#515, that's the perfect link to put in a comment. I suggest reading the blog post that announced the stabilization of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for readability
A Send variant may be nice to use with Embassy's SendSpawner. However, embedded-hal-async traits don't have Send variants, so it's unlikely the that the drivers called in the impl's of this trait would have async fn's that return Send Futures. You probably don't want to be writing different frames to one LED device from multiple threads simultaneously anyway; that would require the driver to implement synchronization to avoid interleaving of separate frames, which would add a run time cost.