fix all warnings, add most missing algos, revamp algorithms.h #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurban
force-pushed
the
new
branch
7 times, most recently
from
3de7222
to
c3dcb9b
Compare
rurban
changed the title
rurban
changed the title
|
Hi, I'm only a contributor to this repo, so won't be reviewing this PR. However, this is a huge amount of change for a single PR. You should consider splitting up your changes into smaller and more focused PRs. This will be easier to review and approve. |
|
Also, hasn't been much activity on this repo for a while. Not sure to what extent it is still being maintained. Don't want you to waste your great effort here! |
but still the flists. GH #7
all but bom, which uses nested functions.
i.e.: make verify ALGOSRC=source/algos/aut.c to check a single file. Fixes GH #9
needs globals cells[], not thread-safe
lots of shared memory leaks. unchecked strcpy, strcat. false _s warnings.
e.g. make CC=x86_64-w64-mingw32-gcc
and fix them
don't honor -pre and -dif anymore. we can switch it back on via radiobutton. the <center> is set via style already.
esp. with TVSBS and UFNDMQ2. no zig-zag ranges
no search_large fallbacks, proper plen checks, but search_small fallbacks.
if UNSATISFIABLE
the binary patterns as C includes against midimusic texts
and not-terminating NUL, and loop termination. restore the original text for the final *text cases.
improved sanitizer.sh with timeout killer
Constraints: needs m space at the end of T but fails now. bin/fs-w4 aba 3 bababababa 10 found 3 occ instead of 4
does not terminate anymore
implement timeout_min. less MAX_M and MAX_N search space with cbmc so unwind is 8*8 = 64 for a 2x nested preMP loop.
and my new cbmc stats_summary patch
and improve CBMC defines
run each size explicitly, not via nondet_int < MAX_M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add a proper Makefile.
algorithms.h is now static