Feat/eliminate use of bytes in function interfaces #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mevtxn
force-pushed
the
feat/eliminate-use-of-bytes-in-function-interfaces
branch
from
61685ec to
0a7be28
Compare
eugene-eko2000
approved these changes
Nov 25, 2024
@eugene-eko2000 yes I mentioned the same in the call as well and asked @mevtxn to do this. By eliminating this parameter all together we make execute and verify simpler and avoid chances of any discrepancies. It is safer to just calculated it and store within the contract itself. |
TokenTitan
requested changes
Nov 27, 2024
eugene-eko2000
approved these changes
Nov 27, 2024
TokenTitan
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.