Feature: open street maps for POIs #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode's analysis on #395dec found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
donni106
requested changes
Dec 3, 2020
donni106
reviewed
Dec 3, 2020
- added osm via react-native-webview-leaflet, own fork to align webview versions SVA-86
- added new screen for testing - added new component that reacts to map marker clicks in a view below
- added map to point of interest details screen - overview screen is now fed with data via query - tapping on a pin will show the point of interest detail card below SVA-86
- added extra query for getting details of a selected POI SVA-86
- reordered the setting of constants - wrapped functions in useCallbacks where necessary - renamed ListHeader to DropdownHeader - we will have a MapSwitchHeader soon SVA-86
- moved the map further down on details view - refactored import to get rid of cycle issues SVA-86
- changed import to get rid of cycles - changed logic to only show - either the activity indicator or the details - never both SVA-86
- added MapSwitchHeader to IndexScreen for POIs - added possibility to switch between LocationOverview and list for POI - removed the no longer needed LocationOverviewScreen - added category filter for LocationOverview SVA-86
- changed prop type to be MapMarker[] instead of Array<MapMarker> SVA-86
- used auto formatting and saved the files SVA-86
- created `ListSwitchItem` file to have a reusable components
for list switches
- updated `MapSwitchHeader` to use the new components
- removed vertical margin from `LocationOverview` as it resulted
in weird looking whitespaces on top and at bottom of the map
- adding color for activity indicator
- and added loading container wrapper to add padding,
otherwise it would be stacked directly underneath the map
SVA-86
- changed the query for geolocations - changed components accordingly SVA-86
- changed the order of arguments to align with prop validation of POI SVA-86
- fixed casing of DropdownHeader.js and its component SVA-86
- fixed: JSX element does not have any construct or call signatures. SVA-86
digorath
force-pushed
the
feature/SVA-86-open-street-maps
branch
from
fc7c712 to
a016f2b
Compare
- changed WrapperWithOrientation to use the context internally - added WrapperWithOrientation to LocationOverview - changed styling of WebViewMap to a default aspect ratio of 16:9 - set default width of WebViewMap to 100% SVA-86
donni106
reviewed
Dec 8, 2020
donni106
reviewed
Dec 8, 2020
donni106
reviewed
Dec 8, 2020
donni106
reviewed
Dec 8, 2020
donni106
requested changes
Dec 8, 2020
added 4 commits
December 9, 2020 16:03
- added proper exports/imports through index files - removed spreading of location with default icon - icon is already mandatory in type, so no need to have a fallback SVA-86
- map size will now be fixed, independent of orientation - this needs to be done due to a bug in react-native 0.63 (facebook/react-native#29451) SVA-86
- changed background color to lightest text color SVA-86
- fixed import grouping in WebViewMap.tsx SVA-86
donni106
reviewed
Dec 9, 2020
DeepCode's analysis on #11f10e found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
|
Code Climate has analyzed commit 11f10e4 and detected 0 issues on this pull request. View more on Code Climate. |
donni106
reviewed
Dec 9, 2020
donni106
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Added a web view map for points of interest.
The map is shown on the details screen for a specific POI.
Furthermore for a selected category of POIs there now is the option to show it as a map instead. If selected you see the map with all the locations of the POIs. If you tap on one pin, the details are shown below.
In the process of adding it to the IndexScreen (category screen) the screen was refactored.
SVA-86