Fix/onramp allowlist race condition #1480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndition Signed-off-by: 0xsuryansh <suryansh.shrivastava@smartcontract.com>
Signed-off-by: 0xsuryansh <suryansh.shrivastava@smartcontract.com>
LCOV of commit
|
0xsuryansh
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
RensR
reviewed
Oct 4, 2024
| @@ -91,6 +91,7 @@ contract OnRamp is IEVM2AnyOnRampClient, ITypeAndVersion, OwnerIsCreator { | |||
| struct DestChainConfigArgs { | |||
| uint64 destChainSelector; // Destination chain selector | |||
| IRouter router; // Source router address | |||
| bool allowListEnabled; // Boolean indicator to specify if allowList check is enabled | |||
There was a problem hiding this comment.
let's add struct packing comments, they should have been there already but the previous person also missed them :)
There was a problem hiding this comment.
# Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot # core/gethwrappers/ccip/generated/onramp/onramp.go # core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
Signed-off-by: 0xsuryansh <suryansh.shrivastava@smartcontract.com>
Signed-off-by: 0xsuryansh <suryansh.shrivastava@smartcontract.com>
|
|
Added a test for setting a new chain with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the
onRamp::_applyDestChainConfigUpdatesis invoked in the constructor, theallowListEnabledfield of the destination chain configuration is not set directly. As a result, if an onRamp with an allow list is required, the deployment must be bundled with a call toonRamp::applyAllowListUpdatesSolution
Directly sets the
allowListEnabledfield during the constructor execution.