[CCIP-5809] execute: handle pseudo-deleted msgs in getFilterObservation#891
Merged
[CCIP-5809] execute: handle pseudo-deleted msgs in getFilterObservation#891
Conversation
The GetMessages observation could potentially include a pseudo-deleted message which is either: - a message that is inflight - a message that has already been executed - a message that was not included in the observation due to size limits In all cases, since we don't need to execute these messages, we don't need to fetch their sender's nonce.
makramkd
commented
May 2, 2025
Comment on lines
+457
to
+459
| // TODO: check if the commit report is all fully executed and inflight messages. | ||
| // Might be able to just not include it in the observation at all? Or is there a | ||
| // risk with that? |
Collaborator
Author
Contributor
There was a problem hiding this comment.
Yeah that makes sense. There's code in here somewhere that attempts to remove fully executed commit reports. Maybe the inflight cache should use seqNum so that we can include it in the "executed message" list to trigger that code.
Collaborator
Author
There was a problem hiding this comment.
makramkd
requested review from
0xAustinWang,
asoliman92,
b-gopalswami,
dimkouv,
matYang,
mateusz-sekara and
winder
|
0xAustinWang
approved these changes
May 3, 2025
Yea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GetMessages observation could potentially include a pseudo-deleted
message which is either:
In all cases, since we don't need to execute these messages, we don't
need to fetch their sender's nonce.