Conversation
makramkd
reviewed
Dec 5, 2025
| with: | ||
| repository: smartcontractkit/chainlink | ||
| ref: becbfb2fc0774c97f7168780563ac9090aa3e3f1 | ||
| ref: 585838629ce2be9fcf3f0ae9d79b72de6b892f08 |
Collaborator
There was a problem hiding this comment.
Is there a reason for bumping or just staying up to date w/ latest develop on chainlink?
Collaborator
There was a problem hiding this comment.
Actually this looks like a non-develop branch, if you can't merge the chainlink PR in time make sure to re-bump after a merge (and keep that branch un-deleted on remote)
Collaborator
Author
There was a problem hiding this comment.
Yeah, I need a fix in a chainlink repo, so I need
- merge in chainlink repo
- merge this branch
- bump to the main version in chainlink repo and merge as well
Comment on lines
-21
to
-22
| docker tag verifier:rc {{registry}}/chainlink-ccv-token-verifier:{{version}}-rc | ||
| docker push {{registry}}/chainlink-ccv-token-verifier:{{version}}-rc |
Collaborator
There was a problem hiding this comment.
Is this no longer needed? If we're running in standalone we'll need these images no?
Collaborator
Author
There was a problem hiding this comment.
It breaks the build, so temporary removing it. It won't be needed until we actuallly need to deploy on staging
makramkd
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.