DF-21518 Secure Mint aggregator: chainSelector passed in as string #1452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
requested changes
Aug 6, 2025
Contributor
jmank88
left a comment
jmank88
left a comment
There was a problem hiding this comment.
uint64 does not work in json.
What do you mean? JSON supports unlimited precision integers and decimals
EasterTheBunny
approved these changes
Aug 6, 2025
jmank88
approved these changes
Aug 6, 2025
Contributor
Author
Discussed offline: JSON indeed supports unlimited precision, the issue seems to be in how we use mapstructure |
jmank88
deleted the
DF-21518-sm-aggregator-chain-selector-parse-from-string
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure Mint aggregator uses a chainSelector, which is a uint64.
This will be passed in as a string because uint64 does not work in json.
Requires
Nothing
Supports
smartcontractkit/chainlink#18841