DF-21518 Remove seq nr validation in secure mint aggregator #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cll-gg
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 12, 2025
cll-gg
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 12, 2025
… capability itself) + add TODO
cll-gg
force-pushed
the
DF-21518-improve-sm-aggregator
branch
from
5d95bc8 to
ff625e1
Compare
cll-gg
changed the title
mchain0
approved these changes
Aug 13, 2025
jmank88
approved these changes
Aug 13, 2025
|
Why remove this? |
Contributor
Author
As I understand it, this is done in the consensus capability itself |
github-merge-queue bot
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 14, 2025
* Make latest cl-common work * Depend on chainlink-common smartcontractkit/chainlink-common#1470 * Use latest cl-common again * More logging * Test passes locally * Update to latest chainlink-common and revert unnecessary logging * Add changeset * Run make tidy * Fix changeset * Use cl-common from main branch * Fix * Fix go.sum as well * Run make tidy
github-merge-queue bot
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 14, 2025
* Make latest cl-common work * Depend on chainlink-common smartcontractkit/chainlink-common#1470 * Use latest cl-common again * More logging * Test passes locally * Update to latest chainlink-common and revert unnecessary logging * Add changeset * Run make tidy * Fix changeset * Use cl-common from main branch * Fix * Fix go.sum as well * Run make tidy * Run make generate after merge * Remove cursor rules
github-merge-queue bot
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 14, 2025
* Make latest cl-common work * Depend on chainlink-common smartcontractkit/chainlink-common#1470 * Use latest cl-common again * More logging * Test passes locally * Update to latest chainlink-common and revert unnecessary logging * Add changeset * Run make tidy * Fix changeset * Use cl-common from main branch * Fix * Fix go.sum as well * Run make tidy * Run make generate after merge * Remove cursor rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Nothing
Supports
smartcontractkit/chainlink#18926