Skip to content

PLEX-1920 add solana devnet into default ChainAllowed list #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmank88 merged 9 commits into from
Feb 2, 2026
Merged

PLEX-1920 add solana devnet into default ChainAllowed list #1787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
05a8719
add solana devnet to defaults
Unheilbar Jan 21, 2026
c7dd5bc
add solana devnet to allowed chains
Unheilbar Jan 21, 2026
abda6ce
fix tests
Unheilbar Jan 23, 2026
bdc12ea
replace devnet with testnet selector
Unheilbar Jan 29, 2026
fc05c52
run tests
Unheilbar Jan 29, 2026
5c11c19
Merge branch 'main' into PLEX-1920_add_defaults
Unheilbar Jan 29, 2026
2b52746
fix converters
Unheilbar Jan 30, 2026
8a3fe99
add capacity prealloc
Unheilbar Feb 2, 2026
036b0eb
Merge branch 'main' into PLEX-1920_add_defaults
Unheilbar Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/chains/solana/proto_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1419,15 +1419,15 @@ func ConvertValueComparatorsToProto(comparators []solprimitives.IndexedValueComp
return nil
}

out := make([]*IndexedValueComparator, len(comparators))
out := make([]*IndexedValueComparator, 0, len(comparators))
for _, c := range comparators {
out = append(out, &IndexedValueComparator{
Value: c.Value,
Operator: chaincommonpb.ComparisonOperator(c.Operator),
})
}

return nil
return out
}

func ConvertValueCompraratorsFromProto(comparators []*IndexedValueComparator) []solprimitives.IndexedValueComparator {
Expand Down
10 changes: 5 additions & 5 deletions pkg/chains/solana/proto_helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,17 +291,17 @@ func TestExpressions_Roundtrip_SolanaPrimitives(t *testing.T) {
{Value: typesolana.IndexedValue{1, 2, 3}, Operator: 0},
})

root := query.Or(query.And(a, e), evBy)

expressions := []query.Expression{a, e, evBy}
// to proto
pb, err := conv.ConvertExpressionsToProto([]query.Expression{root})
pb, err := conv.ConvertExpressionsToProto(expressions)
require.NoError(t, err)
require.Len(t, pb, 1)
require.Len(t, pb, 3)

// from proto
round, err := conv.ConvertExpressionsFromProto(pb)
require.NoError(t, err)
require.Len(t, round, 1)
require.Len(t, round, 3)
require.Equal(t, expressions, round)
}

func TestLPFilterAndSubkeysConverters(t *testing.T) {
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"ChainAllowed": {
"Default": "false",
"Values": {
"12463857294658392847": "true",
"12922642891491394802": "true",
"3379446385462418246": "true"
}
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ LogEventLimit = '1000'
Default = 'false'

[PerWorkflow.ChainAllowed.Values]
12463857294658392847 = 'true'
Copy link
Contributor

@dhaidashenko dhaidashenko Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add mainnet right away?

Copy link
Contributor

@jmank88 jmank88 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left main nets out here by design so that we don't accidentally enable anything prematurely. Originally I had this empty, but added minimal dev/testnets to support testing in CI.

12922642891491394802 = 'true'
3379446385462418246 = 'true'

Expand Down
6 changes: 4 additions & 2 deletions pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,12 @@ var Default = Schema{
LogLineLimit: Size(config.KByte),
LogEventLimit: Int(1_000),
ChainAllowed: PerChainSelector(Bool(false), map[string]bool{
// geth-testnet
"3379446385462418246": true,
// geth-devnet2
"12922642891491394802": true,
// geth-testnet
"3379446385462418246": true,
// solana-testnet
"12463857294658392847": true,
}),

CRONTrigger: cronTrigger{
Expand Down
Loading