Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic heartbeat service #976

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Generic heartbeat service #976

wants to merge 1 commit into from
+113 −0

Conversation

patrickhuie19
Copy link
Contributor

@patrickhuie19 patrickhuie19 changed the title sketch of generic heartbeat service Generic heartbeat service Dec 17, 2024
@pkcll pkcll self-requested a review December 19, 2024 17:50
pkcll
pkcll reviewed Dec 19, 2024
View reviewed changes
pkg/services/heartbeat.go
eng *Engine

beat time.Duration
lggr logger.Logger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we pass beholder client as a dependency here as well. Its same type of concern as logger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm - my thinking with breaking this out was that this heartbeat service could be used in core, loops, and the beholder client as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkcll pkcll pkcll left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickhuie19 @pkcll