-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blockchain anvil zksync #1651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcc08d3
to
8609e35
Compare
|
Tofel
reviewed
Mar 17, 2025
Tofel
reviewed
Mar 17, 2025
Tofel
reviewed
Mar 17, 2025
Tofel
reviewed
Mar 17, 2025
Tofel
reviewed
Mar 17, 2025
Tofel
reviewed
Mar 18, 2025
Tofel
reviewed
Mar 18, 2025
Tofel
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding blockchain
anvil-zksync
that allows to test with a zk vm.The goal is to be able to call it from
chainlink/deployment
environmentThe implementation requires to write a custom Dockerfile because there are no official public distributions. I decided to put the Dockerfile in a temporary folder and delete it after spinning up the container.
containers.go
has Anvils duplicated codeblockchain_test.go
adds unit test for Anvil and Anvil ZksyncWhy
The changes simplify the
newAnvil
function by removing unnecessary context and container setup, focusing on creating a generic Ethereum Virtual Machine (EVM) container. Additionally, they introduce support for a new blockchain simulation environment,anvil-zksync
, including a way to build its Docker image from source due to the lack of public images. This extension enhances the framework's capabilities to include zkSync development environments.What
newAnvil
function to usecreateGenericEvmContainer
without direct Docker container management code.anvil-zksync
with functionsdefaultAnvilZksync
andnewAnvilZksync
for setting up and creating anvil-zksync Docker containers."anvil-zksync"
case toNewBlockchainNetwork
switch statement to handle anvil-zksync blockchain setups.anvil
andanvil-zksync
setups.baseRequest
andcreateGenericEvmContainer
to streamline the creation of blockchain simulation environments.