Revert "adding exclude files + other changes to get registration to work for me"#2079
Merged
Revert "adding exclude files + other changes to get registration to work for me"#2079
Conversation
…ork for …" This reverts commit 2284539.
skudasov
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2036
Doesn't fully work:
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes improve the configuration and error handling for fetching and registering protobuf schemas from GitHub repositories. They simplify the process by removing unnecessary configurations and enhancing the logging mechanism to give more detailed feedback during the process.
What
ExcludeFilesfield fromProtoSchemaSetstruct to simplify configuration.registerAllWithTopologicalSortingByTrialand updated its logic to try registering protos in different orders if necessary, improving robustness.