Add styleguide to workspace #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupurt
force-pushed
the
chores/add-styleguide-to-workspace
branch
2 times, most recently
from
a5f54d4 to
c7b28e6
Compare
rupurt
force-pushed
the
chores/add-styleguide-to-workspace
branch
2 times, most recently
from
0fb5428 to
d7cf8de
Compare
rupurt
force-pushed
the
chores/add-styleguide-to-workspace
branch
8 times, most recently
from
04cbea6 to
08657a3
Compare
- Move OperatorUI theme - Move OperatorUI TimeAgo, Tooltip, KeyValueList, Logo & Image - Move OperatorUI shared cards
rupurt
force-pushed
the
chores/add-styleguide-to-workspace
branch
from
08657a3 to
de8d4e2
Compare
se3000
approved these changes
Jun 27, 2019
|
@se3000 yeah, I'm working on the Typescript support. Adding Typescript support to the styleguide in workspaces has strict checking. This highlighted that there are a bunch of annotations that are missing and are needed to get explorer + styleguide + operator_ui in sync. Actively working on that in this branch |
asoliman92
pushed a commit
that referenced
this pull request
Aug 27, 2024
## Motivation `NonceManager` and `MultiAggregateRateLimiter` contracts were missing `typeAndVersion`. ## Solution Add `ITypeAndVersion` inheritance to both contracts.
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Motivation `NonceManager` and `MultiAggregateRateLimiter` contracts were missing `typeAndVersion`. ## Solution Add `ITypeAndVersion` inheritance to both contracts.
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Motivation `NonceManager` and `MultiAggregateRateLimiter` contracts were missing `typeAndVersion`. ## Solution Add `ITypeAndVersion` inheritance to both contracts.
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Motivation `NonceManager` and `MultiAggregateRateLimiter` contracts were missing `typeAndVersion`. ## Solution Add `ITypeAndVersion` inheritance to both contracts.
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Motivation `NonceManager` and `MultiAggregateRateLimiter` contracts were missing `typeAndVersion`. ## Solution Add `ITypeAndVersion` inheritance to both contracts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test:nocachetask to force a recompile in jestTypescript support is getting worked on in a separate branch as it raises 100's errors across the project and will result in an even larger diff. I've converted the old
tsxcomponents tojsxfor this PR but will restore them totsxwhen the remaining errors are fixed`