-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecotone gas price #12584
Merged
Merged
Ecotone gas price #12584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see you updated files related to |
amit-momin
reviewed
Mar 26, 2024
amit-momin
reviewed
Mar 26, 2024
amit-momin
previously approved these changes
Mar 26, 2024
|
amit-momin
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the Ecotone upgrade, OP stack l1 gas price is no longer simply a query of
l1BaseFee
: https://docs.optimism.io/stack/transactions/fees#ecotoneThe new equations are:
We implement a simpler way to calculate weighted_gas_price:
Experiments show this simpler approach gives a gas price within 1% of the value calculated from the formula.
Referencing GasOracle code: https://vscode.blockscan.com/optimism/0xb528d11cc114e026f138fe568744c6d45ce6da7a, this approach uses the same formula under the hood.
This PR implements an OP Stack data availability price reader (
DAPriceReader
) to abstract the logic out of l1GasOracle.